fix: prevent CSE from extracting window functions - #24750
Open
cdelmonte-zg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Common subexpression elimination can extract duplicated window functions into an intermediate Projection. Since window functions cannot be evaluated by a projection, this produces a plan that fails during physical planning.
What changes are included in this PR?
Exclude WindowFunction expressions themselves from CSE extraction and add a regression test.
Are these changes tested?
Yes. A regression test verifies that duplicated window functions remain in the WindowAggr node.
Are there any user-facing changes?
Queries affected by #15190 no longer fail during physical planning. No documentation changes are required.