bench: add grouped aggregate filter benchmarks - #24748
Open
lyne7-sc wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24748 +/- ##
==========================================
- Coverage 81.47% 81.47% -0.01%
==========================================
Files 1122 1122
Lines 404140 404140
Branches 404140 404140
==========================================
- Hits 329284 329275 -9
- Misses 55546 55548 +2
- Partials 19310 19317 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Aug 30, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Just some optional suggestions and follow-up ideas.
I don't known if we have SQL benchmarks for aggregate queries with filters, if not, we could also add some in: https://github.com/apache/datafusion/tree/main/benchmarks/sql_benchmarks/clickbench_extended
|
|
||
| const NUM_ROWS: usize = 65_536; | ||
| const BATCH_SIZE: usize = 8_192; | ||
| const NUM_GROUPS: usize = 1_024; |
Contributor
There was a problem hiding this comment.
I think this is a key axis to vary, we could add a very small and a very high cardinality variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add a microbenchmark for measuring grouped aggregate
FILTERperformance across different filter selectivities and aggregate layouts.What changes are included in this PR?
AggregateExecmicrobenchmark for grouped aggregates withFILTER.Are these changes tested?
Yes.
Are there any user-facing changes?
No.