fix(proto): check integer conversions in common options and constraints - #24726
Open
buraksenn wants to merge 1 commit into
Open
fix(proto): check integer conversions in common options and constraints#24726buraksenn wants to merge 1 commit into
buraksenn wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24726 +/- ##
==========================================
- Coverage 81.44% 81.44% -0.01%
==========================================
Files 1120 1120
Lines 401605 401871 +266
Branches 401605 401871 +266
==========================================
+ Hits 327098 327287 +189
- Misses 55348 55366 +18
- Partials 19159 19218 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
usizeon 32-bit targets #24170.Rationale for this change
#24483 added checked integer conversions across logical and physical plan serialization. Common protobuf conversions for file-format options and constraints still used unchecked casts, allowing oversized values to silently truncate on 32-bit targets.
What changes are included in this PR?
The protobuf wire format is unchanged.
Are these changes tested?
Yes. Existing option round-trip tests pass, and tests cover the fallible public conversion contracts and malformed constraints.
Are there any user-facing changes?
Oversized protobuf values now return an error instead of silently truncating.
Some public
Fromconversions are nowTryFrom, so downstream callers must handle the resulting error. This migration is documented in the 56.0.0 upgrade guide.