Skip to content

fix: array_sort doesnt respect array inputs for sort order/nulls first - #24502

Draft
JSOD11 wants to merge 6 commits into
apache:mainfrom
JSOD11:jsod/array-sort-options-08-19-26
Draft

fix: array_sort doesnt respect array inputs for sort order/nulls first#24502
JSOD11 wants to merge 6 commits into
apache:mainfrom
JSOD11:jsod/array-sort-options-08-19-26

Conversation

@JSOD11

@JSOD11 JSOD11 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.82143% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.57%. Comparing base (e2e161d) to head (9ff5b5e).
⚠️ Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/functions-nested/src/sort.rs 84.82% 8 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24502      +/-   ##
==========================================
+ Coverage   81.27%   81.57%   +0.29%     
==========================================
  Files        1114     1123       +9     
  Lines      393619   406688   +13069     
  Branches   393619   406688   +13069     
==========================================
+ Hits       319931   331773   +11842     
- Misses      54950    55469     +519     
- Partials    18738    19446     +708     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the functions Changes to functions implementation label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

array_sort doesnt respect array inputs for sort order/nulls first

2 participants