new tenant instead of add account - #13981
DaanHoogland wants to merge 2 commits into
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13981 +/- ##
=========================================
Coverage 20.05% 20.05%
- Complexity 20656 20658 +2
=========================================
Files 6427 6427
Lines 584905 584907 +2
Branches 71658 71658
=========================================
+ Hits 117278 117279 +1
- Misses 454802 454805 +3
+ Partials 12825 12823 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.00% |
| Branch coverage | 19.27% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
|
Dear @DaanHoogland, Thank you for taking this nomenclature issue seriously and working on a fix. This is also a constant source of confusion in our organization. Regarding ACS's use of the word "Account," you recently labeled it "New Tenant Account." While this is an improvement, it may still cause some confusion. Have you considered using "Department" or "Organizational Unit" instead? Regards, |
|
@daviftorres I agree with your recommendations in the scope of a corporate organization. But think of a public cloud where each account could represent a single user. AWS also names it accounts. So maybe renaming is not needed. Just decouple accounts from users and don't have them in the same dialog. |
|
@DaanHoogland a few thoughts and observations:
|
I see your point and makes sense. But I guess there is no size fits all for this case. And the word "account" is misleading. I am fine with what ever @DaanHoogland decide, but I still think we should diverge the attention of the administrator to the user creation page. |
|
@luganofer closed his issue and I am not sure how to continue. He raised a serious design issue which is not in line with the UI fix I am creating here. How do you think we should continue, @ingox @davift ? |
Sorry for the confusion – I closed the issue accidentally while trying to reply. It's reopened now. |
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19159 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical and moderate issues affect account targeting, action rendering, and localization.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (4)
What changed in this PR
This PR distinguishes tenant-account creation from adding users to an existing account.
Changes:
- Renames account creation to “New Tenant Account.”
- Adds account-scoped user creation with account/domain prefilling.
- Adds tenant-isolation warning and English localization.
| File | Summary and findings |
|---|---|
ui/src/views/iam/AddUser.vue |
Prefills account/domain; critical stale-resource issue (1 vote) may create users under the wrong account. |
ui/src/views/iam/AddAccount.vue |
Adds the tenant-creation warning. |
ui/src/config/section/account.js |
Adds account user action; critical list-level action may target the first account (4 votes), and moderate icon/label is unregistered or unrecognized (2 votes). |
ui/public/locales/en.json |
Adds labels and warning text; moderate existing API-unavailable translation is overwritten (3 votes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| listView: true, | ||
| dataView: true, |
| this.account = (this.$route.query && this.$route.query.account) || this.resource?.name || null | ||
| this.domainid = (this.$route.query && this.$route.query.domainid) || this.resource?.domainid || null |
| "message.action.vmsnapshot.disk-only.delete": "Please confirm that you want to delete this Instance Snapshot.", | ||
| "message.activate.project": "Are you sure you want to activate this project?", | ||
| "message.api.not.available": "API is not available.", | ||
| "message.add.account.warning": "Creating a new account creates a separate tenant with its own resource limits and isolated resources. Users in different accounts cannot share Instances or Volumes. Networks can be shared between accounts when the appropriate permissions are granted. To add a new user to an existing account instead, use the <b>Add User</b> action from the account's list or details view.", |
| }, | ||
| { | ||
| api: 'createUser', | ||
| icon: 'usergroup-add-outlined', |
|
Description
This PR...
Fixes: #13975
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?