GH-38217: [R] Map format = "text" to format = "csv" in write_dataset() - #50367
Open
thisisnic wants to merge 4 commits into
Open
GH-38217: [R] Map format = "text" to format = "csv" in write_dataset()#50367thisisnic wants to merge 4 commits into
thisisnic wants to merge 4 commits into
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the R write_dataset() format handling with open_dataset() by treating format = "text" as an alias of CSV, so users can write delimited text datasets with the same expectations as when opening them.
Changes:
- Map
format = "text"to"csv"insidewrite_dataset()so it uses CSV defaults (notably comma delimiter) and generates.csvfilenames. - Narrow the “delimiter required” validation to only apply to
format = "txt", avoiding the previous error forformat = "text". - Update tests to cover the new
format = "text"behavior and remove the old expectation that it errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| r/R/dataset-write.R | Adds text -> csv mapping and updates delimiter validation to only enforce a delimiter for txt. |
| r/tests/testthat/test-dataset-write.R | Replaces the previous error expectation for format="text" with a round-trip test asserting .csv output and correct data. |
thisisnic
marked this pull request as draft
July 5, 2026 13:48
thisisnic
force-pushed
the
worktree-GH-38217-text-to-csv
branch
from
August 18, 2026 13:49
d048f45 to
4292634
Compare
thisisnic
marked this pull request as ready for review
August 18, 2026 13:49
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
r/R/dataset-write.R:156
- PR description says there are no user-facing changes, but this change makes
write_dataset(format = "text")succeed where it previously errored (a user-visible behavior change). Consider updating the PR description/release-note wording to reflect this bugfix.
if (format == "text") {
format <- "csv"
}
thisisnic
force-pushed
the
worktree-GH-38217-text-to-csv
branch
from
August 25, 2026 10:07
4292634 to
85d49ac
Compare
thisisnic
commented
Aug 25, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, matches the linked issue’s acceptance criteria, and is covered by an explicit regression test.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
write_dataset()errors onformat="text"even thoughopen_dataset()allows it.What changes are included in this PR?
Map "text" to "csv" so
write_dataset()mirrorsopen_dataset()Are these changes tested?
Yes
Are there any user-facing changes?
No
format = "texttoformat = "csv"inwrite_dataset()#38217