Skip to content

fix(desktop): deliver deep links once - #46863

Open
opencode-agent[bot] wants to merge 1 commit into
v2from
electron-audit-14
Open

opencode-agent[bot] wants to merge 1 commit into
v2from
electron-audit-14

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • report whether a renderer event has an active IPC sink
  • deliver deep links live when the renderer can receive them
  • queue links only when live delivery is unavailable
  • cover event availability before binding, while bound, and after unbinding

Why

Desktop always queued each deep link and also emitted it to a live renderer. The same link was therefore handled immediately, then replayed from the pending queue after a renderer reload. Delivery is now mutually exclusive: live or queued, never both.

Checks

  • GOMAXPROCS=1 GOMEMLIMIT=1500MiB bun typecheck (packages/desktop)
  • bun test src/main/ipc-events.test.ts src/main/ipc-transport.test.ts (2 pass)
  • bun x prettier --check src/main/ipc-events.test.ts src/main/ipc-events.ts src/main/lifecycle/index.ts
  • git diff --check
  • full desktop bun test: 92 pass, 1 Windows-only skip; host Node 18 lacks node:sqlite for drafts.test.ts

Requested by: @Hona (Hona via Slack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant