refactor(core): reuse formatter file extension - #46080
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each formatting request recalculates the same filename extension for every registered formatter. The extension depends only on the requested path.
What Changes
Compute
path.extname(filepath)once before selecting matching formatters. Matching remains case-sensitive and uses the same Node path semantics, registry order, and first-success/fallback behavior.Scope
The matching expression and focused matching tests only. Command resolution, process execution, timeout policy, and error handling are unchanged.
Verification
17 tests passed with 24 assertions. New real-harness cases cover matching/nonmatching extensions, case sensitivity, dotfiles, extensionless files, and multi-dot names. Core typechecking, formatting, and whitespace checks passed.