refactor(core): reuse Markdown chunk byte counts - #46079
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
HTML-to-Markdown rendering encodes each appended chunk to measure its UTF-8 size, then encodes the same string again when it fits unchanged. The second encoding allocates a redundant byte array for the common path.
What Changes
Reuse the first byte count when the chunk fits. If truncation changes the string, continue measuring the retained prefix as before. Output text, byte budgets, and room reserved for closing syntax are unchanged.
Scope
One production expression and three boundary cases in the existing webfetch tests. No tool contracts or parser chunking changes; this does not address the existing surrogate-pair splitting behavior at parser chunk boundaries.
Verification
57 tests passed with 102 assertions. Typechecking, formatting, and whitespace checks passed. Added cases cover fitting and truncated ASCII, two-byte, and four-byte UTF-8 content, with surrogate pairs aligned to parser chunks. No throughput benchmark claim.