fix(cdk): add @angular/forms to peer dependencies - #33666
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Hi, @andrewseguin @ok7sai! Fixed the cla check, can you please take a look at the PR? Thank you! LE: added info on how to reproduce in the description. |
crisbeto
approved these changes
Aug 27, 2026
crisbeto
added
action: merge
Member
crisbeto
pushed a commit
that referenced
this pull request
Aug 27, 2026
(cherry picked from commit 9ed16f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entry points such as
@angular/cdk/stepperand@angular/cdk/listboximport runtime symbols from@angular/forms, but the package is not listed in the CDK peer dependencies.This can cause module resolution failures with package managers that enforce dependency isolation, such as pnpm with global virtual store.
You can reproduce it from this repo: https://github.com/caleniuc/angular-cdk-forms-repro
Will throw this error: