fix dialog backend on MacOS - #32
Merged
Merged
Conversation
This revision fixes an issue where the Unix dialog backend is compiled for MacOS builds causing OS dialog windows to fail. This fix adds SDL_cocoadialog.m to the `cocoa` source group and adds a new `unix_dialog` source group to contain the unix, portal, and zenity dialog backends.
nmacholl
force-pushed
the
nick/fix_macos_cocoa
branch
from
September 17, 2026 03:53
b6f84de to
a432799
Compare
Contributor
|
Thanks for the PR! I was tempted to suggest that we just move these files to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This revision fixes an issue where the Unix dialog backend is compiled for MacOS builds causing OS dialog windows to fail.
Here is an example error:
File dialog driver unsupported (supported values for SDL_HINT_FILE_DIALOG_DRIVER are 'zenity' and 'portal')Resolution
This revision delivers two changes. First,
SDL_cocoadialog.mis added to thecocoasource group and a newunix_dialoggroup is added containing the Unix dialog backends. Second, theunix_dialoggroup is added to the C source files in src/linux.zig to make the Linux build whole.Verification
Verified with a small example program, which fails with the above error prior to this fix, but opens dialogs correctly after.