Skip to content

docs(ack-pay): fix invalid new BigInt() in README example - #212

Open
kutluhaneth46 wants to merge 1 commit into
agentcommercekit:mainfrom
kutluhaneth46:cursor/fix-ack-pay-bigint-readme-88c1
Open

docs(ack-pay): fix invalid new BigInt() in README example#212
kutluhaneth46 wants to merge 1 commit into
agentcommercekit:mainfrom
kutluhaneth46:cursor/fix-ack-pay-bigint-readme-88c1

Conversation

@kutluhaneth46

@kutluhaneth46 kutluhaneth46 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The ack-pay README payment-request example used new BigInt(...), which throws TypeError: BigInt is not a constructor.
  • Switch to BigInt(100_000_000).toString() so the snippet is copy-paste runnable.

Docs-only. No open/closed PR or issue covers this.

Testing

  • Confirmed new BigInt(100) throws; BigInt(100_000_000).toString()"100000000".

AI usage disclosure

Assisted by Cursor. I verified the runtime error and the corrected form before submitting.

Summary by CodeRabbit

  • Documentation
    • Corrected the payment request example to use valid BigInt syntax.

BigInt is not a constructor; new BigInt(...) throws TypeError.
Use BigInt(100_000_000).toString() so the payment-request example runs.
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c6a575fd-5015-4ba4-8c98-87ed4d422cd6

📥 Commits

Reviewing files that changed from the base of the PR and between 843e396 and a76f119.

📒 Files selected for processing (1)
  • packages/ack-pay/README.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The README payment request example now uses BigInt(100_000_000).toString() without the invalid new keyword.

Changes

Payment request example

Layer / File(s) Summary
Correct the amount constructor
packages/ack-pay/README.md
The example now calls BigInt without new.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a76f1

The payment-request README example now produces the amount string without throwing, making the documented snippet runnable. No merge-blocking risk remains.

Suggested reviewers: venables

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation fix from invalid new BigInt() usage to valid BigInt() usage in the ack-pay README.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant