docs(ack-pay): fix invalid new BigInt() in README example - #212
docs(ack-pay): fix invalid new BigInt() in README example#212kutluhaneth46 wants to merge 1 commit into
Conversation
BigInt is not a constructor; new BigInt(...) throws TypeError. Use BigInt(100_000_000).toString() so the payment-request example runs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe README payment request example now uses ChangesPayment request example
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The payment-request README example now produces the amount string without throwing, making the documented snippet runnable. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
new BigInt(...), which throwsTypeError: BigInt is not a constructor.BigInt(100_000_000).toString()so the snippet is copy-paste runnable.Docs-only. No open/closed PR or issue covers this.
Testing
new BigInt(100)throws;BigInt(100_000_000).toString()→"100000000".AI usage disclosure
Assisted by Cursor. I verified the runtime error and the corrected form before submitting.
Summary by CodeRabbit