Conversation
Align @PARAM tags and examples with the real (chainId, address) signature, and use a full Solana CAIP-2 chain ID in the example. Fixes agentcommercekit#206
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughChangesDID PKH documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Documentation now shows createDidPkhUri with chainId before address and valid CAIP-2 examples. No production behavior changes are introduced, and no merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
venables
left a comment
There was a problem hiding this comment.
Thank you for the correction; verified against the signature and the demo call sites.
|
Thanks for the review and merge, @venables. |
Summary
createDidPkhUriJSDoc@paramorder and examples with the real(chainId, address)signature.solana.Testing
packages/did/README.mdand existing call sites.AI usage disclosure
Assisted by Cursor. I confirmed the signature/docs mismatch against README and runtime call sites before submitting.
Fixes #206
Summary by CodeRabbit
createDidPkhUridocumentation to reflect the correct parameter order.