fix: persist ACP model and reasoning effort across turns and resume - #394
Closed
superbiche wants to merge 8 commits into
Closed
fix: persist ACP model and reasoning effort across turns and resume#394superbiche wants to merge 8 commits into
superbiche wants to merge 8 commits into
Conversation
(cherry picked from commit a943bce)
(cherry picked from commit edd908b)
(cherry picked from commit 3487c8b)
(cherry picked from commit 10f6541)
…onfig-rebased # Conflicts: # src/CodexAcpClient.ts # src/__tests__/CodexACPAgent/CodexAcpClient.test.ts # src/__tests__/CodexACPAgent/session-config-options.test.ts
superbiche
changed the title
Author
|
This conflicted branch has been superseded by #457, rebased onto current I left this PR open rather than rewriting its published history; maintainer review should continue on #457. @superbiche · user · drafted with Codex (GPT-5). |
Author
|
Closing in favor of #457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refreshes @gilbertl's #337 onto current
main(v1.7.0), preserving the original commits and authorship while resolving the conflicts. The scope is intentionally narrower than the earlier revision: model and reasoning-effort persistence only; agent-mode behavior remains identical to upstreammain.What changes:
modelandreasoning_effortconfiguration updates are persisted withthread/settings/updateand acknowledged only after Codex accepts them. A setting therefore remains effective for subsequent turns and process reconnects until changed.modelProvider: "openai"when no provider is configured. Omitting it lets the Codex thread retain its stored model and reasoning effort.Validation on the final candidate (
0275316):npm run typecheck: passnpm test: 486 passed, 27 skippednpm run bundle:all: all six platform bundles passnpm run build: passhigh→low; after two independent adapter restarts, both resume and load reportedlowPASS; agent-mode persistence was removed during review instead of adding concurrency complexity unrelated to this fixKnown boundary: concurrent ACP callers can still race a setting update against a prompt already in flight. The deployed
acpxflow is sequential and waits for the setting acknowledgement before sending the next prompt.Transport-level effective-config receipts need an authoritative app-server receipt, and per-invocation effort for one-shot
acpx execbelongs inacpx; neither is bundled into this adapter fix.Fixes #336.
Fixes #343.
@superbiche · user · drafted with Codex (GPT-5).