Add required phrase model command wrapper - #5267
Open
Kaushik-Kumar-CEG wants to merge 1 commit into
Open
Kaushik-Kumar-CEG wants to merge 1 commit into
Kaushik-Kumar-CEG wants to merge 1 commit into
Conversation
Kaushik-Kumar-CEG
marked this pull request as draft
August 16, 2026 17:46
Kaushik-Kumar-CEG
force-pushed
the
gsoc/review-ml-phrases
branch
from
September 7, 2026 15:21
c721c08 to
c6ad2d7
Compare
Kaushik-Kumar-CEG
marked this pull request as ready for review
September 7, 2026 15:21
Shriprasad-P
left a comment
There was a problem hiding this comment.
Review
PR: Add review workflow to approve predicted phrases before injection
Touched: etc/scripts/dataset_pipeline/add_ml_phrases.py, etc/scripts/dataset_pipeline/review_ml_phrases.py, etc/scripts/dataset_pipeline/test_add_ml_phrases.py, etc/scripts/dataset_pipeline/test_review_ml_phrases.py
- Addresses a concrete correctness/reliability issue based on the title and diff.
- Security-sensitive change — please double-check edge cases and defaults.
- CI/tooling change — confirm the pipeline still passes on this branch.
- Diff is fairly large (+1740/-0); a short summary of risk areas from the author would help reviewers.
Commenting as a drive-by reviewer after reading the diff. Happy to look again if maintainers want a deeper pass on a specific file.
Author
|
Update: the complete review workflow now lives in the dedicated |
Signed-off-by: Kaushik Kumar <kaushikrjpm10@gmail.com>
Kaushik-Kumar-CEG
force-pushed
the
gsoc/review-ml-phrases
branch
from
September 20, 2026 21:53
c6ad2d7 to
4993b06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a small optional maintenance runner for the
scancode-required-phrasespackageThe package already installs
add-model-required-phraseswhich is the normal way to use the workflow. This runner gives maintainers working from a scancode Toolkit checkout a visible way to launch the same command. It also explains how to install the package when it is unavailableboth commands use the same package implementation:
model prediction, review sessions, validation,and rule updates remain in the package. Toolkit does not include duplicate ML code or additional inference dependencies
Test it with: