curriculum: add actionable assertion messages to generators checks - #153
Open
Ali-Nawaz-devt wants to merge 1 commit into
Open
Ali-Nawaz-devt wants to merge 1 commit into
Ali-Nawaz-devt wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
Closes #91
Summary
Adds actionable assertion messages to all 24 currently bare assertions across the 7 generators check files (14 from #90, 10 from #91). Preserves every assertion predicate, execution order, helper statement, and success print. Two asserts (
next(c) == 0,next(c) == 1in generators9.py) use static messages rather than echoing the actual value, sinceCounteris a stateful iterator and re-callingnext(c)inside the message would advance it and corrupt the rest of the test sequence.Validation
python -m pytest tests/integration/test_solution_verify.py -q— 1 passedpython -m pytest -q— 215 passedpythonlings --root tests/fixtures/passing_curriculum verify— passing1, passing2 passed