feat(sse): add SSEParserConfig, raise default per-line limit to 1 MB - #1149
Open
ehsavoie wants to merge 1 commit into
Open
feat(sse): add SSEParserConfig, raise default per-line limit to 1 MB#1149ehsavoie wants to merge 1 commit into
ehsavoie wants to merge 1 commit into
Conversation
ehsavoie
force-pushed
the
issue_1123
branch
from
September 10, 2026 08:35
21f8e51 to
6d60a89
Compare
kabir
reviewed
Sep 10, 2026
ehsavoie
force-pushed
the
issue_1123
branch
2 times, most recently
from
September 11, 2026 10:03
c0569cb to
0e88bb7
Compare
ehsavoie
changed the title
ehsavoie
force-pushed
the
issue_1123
branch
from
September 11, 2026 15:21
0e88bb7 to
ce37b22
Compare
- Introduce SSEParserConfig record with builder to make SSE parser limits (maxLineLength, maxBufferLines, maxBufferChars) configurable - Raise default per-line limit from 64 KB to 1 MB so large JSON-RPC responses are no longer silently dropped - Thread SSEParserConfig through all HTTP client implementations (JDK, Android, OkHttp) via new constructors and provider methods - Prevent corrupt/skipped event blocks from advancing lastEventId, which could cause event loss on reconnect - Add AbstractA2AHttpClientSSETest for shared cross-client SSE tests - Document SSEParserConfig usage and security considerations Fixes a2aproject#1123 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
force-pushed
the
issue_1123
branch
from
September 11, 2026 16:28
ce37b22 to
51b923f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
limits (maxLineLength, maxBufferLines, maxBufferChars) configurable
responses are no longer silently dropped
(JDK, Android, OkHttp) via new constructors and provider methods
which could cause event loss on reconnect
Fixes #1123 🦕