Toolbar: remove white background from transparent site icon - #13289
Toolbar: remove white background from transparent site icon#13289fushar wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This feels valid to me. It's good to have the square silhouette for site logos when any arbitrary image is used, but we shouldn't necessarily enforce a square shape for logos that feature transparency. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/65974
This PR removes white background from transparent site icons. This is done so that site icons maintain their original shape.
I actually implemented the initial background color so that the site icons are consistently square, but now that the feature is live and I've seen some client sites, I think it's a mistake. In some brands, the shape of a transparent site icon gets weird with the added white rounded square.
With this change, these 4 places are now consistent:
Solid site icon (no change)
Toolbar
Settings -> General
Site Editor -> Identity
Actual browser Chrome tab
Transparent site icon
Toolbar - BEFORE vs AFTER
Settings -> General - BEFORE vs AFTER
Site Editor -> Identity
Actual browser (Chrome) tab
Use of AI Tools
Used Claude Code, Opus 5 to help generate the CSS changes.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.