Conversation
jgaleotti
requested changes
Sep 23, 2026
| * condition) or be parsed as a literal text term, since neither can be told apart syntactically | ||
| * from a plain word. | ||
| */ | ||
| public class RedisSearchQueryParser { |
Collaborator
There was a problem hiding this comment.
Any reason for having this low-level parser instead of using an ANTLR grammar?
Collaborator
Author
There was a problem hiding this comment.
This was actually one of the items I wanted to discuss. The idea behind this parser is to keep it as simple as possible, and it's tied to simplifing the actual grammar of Redis queries, making heuristic calculations easier too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added heuristic calculations for new Jedis commands.
Added e2e tests with saving data endpoints.