Merged
Conversation
…4J switch and a spring-rest-neo4j e2e module covering session and transactional queries
jgaleotti
approved these changes
Sep 17, 2026
arcuri82
requested changes
Sep 21, 2026
| @RequestMapping(path = "/neo4jsessionfindnode") | ||
| public class Neo4jSessionFindNodeRest extends AbstractNeo4jRest { | ||
|
|
||
| @PostMapping("/person/{name}") |
Collaborator
There was a problem hiding this comment.
based on Black-Box heuristics (not necessarely now, but in future) it could connect a POST:/person/{name} to a GET:/findPerson/{name}. To avoid this, and make more likely that finding the solution is for Neo4J heuristics and not something else, I would rename POST:/person/{name} into something like POST:/x/foo/{y}/bar
| @@ -0,0 +1,37 @@ | |||
| package com.neo4j; | |||
Collaborator
There was a problem hiding this comment.
this get confusing with the real org.neo4j. maybe call it com.foo.neo4j?
|
|
||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.web.context.request.WebRequest; | ||
| import springfox.documentation.builders.ApiInfoBuilder; |
Collaborator
There was a problem hiding this comment.
should not use springfox for new modules, but rather SpringDoc
…hange the POST path
arcuri82
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentMR_NEO4Jadded toEMConfig, experimental and off by default like the ones for Redis and DynamoDB, plus its entry indocs/options.md. It was missing: all the Neo4j method replacements belong toReplacementCategory.NEO4J, whichmethodReplacementCategories()never listed, so no Cypher query was captured in an actual searchspring-rest-neo4j, following the structure ofspring-rest-redis: a Testcontainers-basedNeo4jController, and oneApp/Rest/ controller /EMTestper scenarioPOSTthat creates a node and aGETthat returns 200 or 404 depending on whether aMATCHfinds it:sessionruns its queries withSession.run,transactionruns them insidereadTransaction(tx -> tx.run(...))GET