Conversation
with conditional compilation to preserve back compability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity UI Extensions - Pull Request
Overview
Updated the package to support Unity 6.6 API changes while preserving backward compatibility with older Unity versions through conditional compilation.
This includes the new
totalMaxparameter inLayoutGroup.SetLayoutInputForAxis, the newmaxWidth/maxHeightmembers inILayoutElement, and removal of deprecateduseLegacyMeshGenerationassignments on Unity 6.6+.Changes
Updated
SetLayoutInputForAxiscalls inFlowLayoutGroupandTableLayoutGroupfor Unity 6.6+:LayoutUtility.DefaultMaxSizefor layouts without an upper size limit.max == preferredfor tables with fixed column widths.maxfor vertically flexible table layouts (flexible = 1).Added conditional compilation to keep the existing 4-argument
SetLayoutInputForAxisAPI on Unity versions older than 6.6.Updated
ExtensionMethodsandColorPickerPresetsto useGetEntityId/GetInstanceIDwith appropriate Unity version checks.Implemented
maxWidthandmaxHeightinUIPrimitiveBasefor Unity 6.6+, usingLayoutUtility.DefaultMaxSizewithout an upper limit.Removed
useLegacyMeshGenerationassignments fromUIPrimitiveBaseandSectoron Unity 6.6+, where the property is deprecated.Preserved compatibility with older Unity versions through
#if UNITY_6000_6_OR_NEWERand#if UNITY_6000_5_OR_NEWER.Fixes: BUG: Object.GetInstanceID()' is obsolete for 6000.5.6f1 #532
Fixes: BUG: Compilation problems for classes implementing ILayoutElement in 6000.6 #534
Breaking Changes
Existing projects using Unity versions older than 6.6 continue to use the previous APIs through conditional compilation.
Related Submodule Changes
Testing status
Manual testing status
LayoutGroup.SetLayoutInputForAxisAPI.FlowLayoutGroupandTableLayoutGroupuse the correctmaxvalues on Unity 6.6+.UIPrimitiveBaseimplements the newILayoutElement.maxWidthandmaxHeightmembers on Unity 6.6+.useLegacyMeshGenerationassignments are excluded on Unity 6.6+.CS7036errors caused by the changedSetLayoutInputForAxissignature are resolved.