trunk shadow changes: com.unity.probuilder - #699
Conversation
|
|
There was a problem hiding this comment.
💡 Harness Review
The change updates legacy shader output semantics and conditionally skips known CoreCLR-incompatible tests, but one CoreCLR template-generation path remains enabled.
The CoreCLR exclusion is incomplete for template generation. Extrude_Face_CreatesValidGeometry remains runnable and, when PB_CREATE_TEST_MESH_TEMPLATES is enabled, calls TestUtility.SaveAssetTemplate at Tests/Runtime/MeshOps/ExtrudeTests.cs:197. That helper uses the same StackTrace/GetFileName() path resolution cited by these new exclusions; on CoreCLR it returns no path, so template regeneration for this test fails (and its caught exception is logged). Exclude this test for that configuration too, or make the template helper accept an explicit path rather than relying on stack frames.
Reviewed commit 9b36250
🤖 Helpful? 👍/👎
This PR contains changes made to the
trunkcopies ofcom.unity.probuilderandcom.unity.probuilder.tests.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.The bot commit 9b36250 was created on top of the package release commit. You may need to cherrypick the commit to a freshly created branch.
Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.probuilderbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.