Skip to content

trunk shadow changes: com.unity.probuilder - #699

Open
pets-svc[bot] wants to merge 1 commit into
release/6.1from
shadow-package/com.unity.probuilder
Open

trunk shadow changes: com.unity.probuilder#699
pets-svc[bot] wants to merge 1 commit into
release/6.1from
shadow-package/com.unity.probuilder

Conversation

@pets-svc

@pets-svc pets-svc Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This PR contains changes made to the trunk copies of com.unity.probuilder and com.unity.probuilder.tests.

This usually means that breaking changes has landed in the trunk Editor, necessitating matching changes to your package code. trunk is therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.

The bot commit 9b36250 was created on top of the package release commit. You may need to cherrypick the commit to a freshly created branch.

Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.

Note: The shadow-package/com.unity.probuilder branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:

git fetch origin shadow-package/com.unity.probuilder:mybranch
git checkout mybranch

If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.

@cla-assistant-unity

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

LGTM

The change updates legacy shader output semantics and conditionally skips known CoreCLR-incompatible tests, but one CoreCLR template-generation path remains enabled.

P2

The CoreCLR exclusion is incomplete for template generation. Extrude_Face_CreatesValidGeometry remains runnable and, when PB_CREATE_TEST_MESH_TEMPLATES is enabled, calls TestUtility.SaveAssetTemplate at Tests/Runtime/MeshOps/ExtrudeTests.cs:197. That helper uses the same StackTrace/GetFileName() path resolution cited by these new exclusions; on CoreCLR it returns no path, so template regeneration for this test fails (and its caught exception is logged). Exclude this test for that configuration too, or make the template helper accept an explicit path rather than relying on stack frames.

Reviewed commit 9b36250

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants