Skip to content

[NGOv3.X] CI fixes and adjustments - #4163

Merged
michalChrobot merged 13 commits into
develop-3.x.xfrom
ngo/updates-after-3-0
Sep 18, 2026
Merged

michalChrobot merged 13 commits into
develop-3.x.xfrom
ngo/updates-after-3-0

Conversation

@michalChrobot

@michalChrobot michalChrobot commented Sep 16, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

Includes few fixes following on 3.X release which are:

  1. Fixes Package Pack (and x-ray) - NGO [win] job
  2. Fixes iOS build job (issue was from the fact that now we pull N4E and other packages and that required more space
  3. I'm also readding "com.unity.services.multiplayer": "2.3.3" to our testproject as that version is compatible
  4. I also did some CI adjustments on the way to make it more intuitive

Jira ticket

N/A

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

Will run full CI to catch any other issues

Up-port

N/A

Backports

N/A

@michalChrobot michalChrobot self-assigned this Sep 16, 2026
@michalChrobot
michalChrobot requested review from a team and jabbacakes as code owners September 16, 2026 12:13
@u-pr

u-pr Bot commented Sep 16, 2026

Copy link
Copy Markdown

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.


Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:
# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The iOS linker postprocessor is correctly scoped to supported iOS builds, and the multiplayer dependency remains consistent across both test manifests and CI workflows.

Reviewed commit a8f9ec1

🤖 Helpful? 👍/👎

@jabbacakes jabbacakes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You summoned me with your one line docs change. 👁️ Few small suggestions to polish the tweaks Noel made after my pass in the last PR.

Comment thread com.unity.netcode.gameobjects/Documentation~/upgrade-guide.md Outdated
Comment thread com.unity.netcode.gameobjects/Documentation~/upgrade-guide.md Outdated
Comment thread com.unity.netcode.gameobjects/Documentation~/upgrade-guide.md Outdated
@codecov-github-com

codecov-github-com Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-3.x.x    #4163      +/-   ##
=================================================
+ Coverage          78.01%   78.19%   +0.18%     
=================================================
  Files                153      153              
  Lines              26260    26272      +12     
=================================================
+ Hits               20486    20544      +58     
+ Misses              5774     5728      -46     
Flag Coverage Δ
NGOv2_project_testproject_ubuntu 76.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 78.19% <95.58%> (+0.18%) ⬆️

ℹ️ Need help interpreting these results?

@michalChrobot
michalChrobot merged commit c3c8655 into develop-3.x.x Sep 18, 2026
6 of 24 checks passed
@michalChrobot
michalChrobot deleted the ngo/updates-after-3-0 branch September 18, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants