Skip to content

ci: [NGOv2.X] Adjusting CI after 3.X release - #4162

Merged
michalChrobot merged 7 commits into
develop-2.0.0from
ngo/develop-ci-adjustmnent
Sep 18, 2026
Merged

michalChrobot merged 7 commits into
develop-2.0.0from
ngo/develop-ci-adjustmnent

Conversation

@michalChrobot

Copy link
Copy Markdown
Member

Purpose of this PR

PR to adjust CI in few places after we released NGOv3.X

  1. Adds MaximumEditorVersion = "6000.6" to Wrench as higher editors will be supported by NGOv3.X
  2. Updates Wrench to latest version and regenerates recipes (so the above change gets applied)
  3. Adjusts our CI as we can remove pinned_trunk, trunk and 6000.5 editor which is now EOL

Jira ticket

N/A

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

I will run full CI just to see if everything works as expected

Up-port

N/A

Backports

N/A

@michalChrobot michalChrobot self-assigned this Sep 16, 2026
@u-pr

u-pr Bot commented Sep 16, 2026

Copy link
Copy Markdown

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.


Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:
# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The CI/editor-matrix update is internally consistent except for one nightly dependency that targets a job the revised coverage template no longer generates.

Reviewed commit bd33485

🤖 Helpful? 👍/👎

Comment thread .yamato/_triggers.yml Outdated
# Run code coverage test (nightly uses actual trunk)
- .yamato/code-coverage.yml#code_coverage_project_test_testproject_ubuntu_trunk
# Run code coverage test
- .yamato/code-coverage.yml#code_coverage_project_test_testproject_ubuntu_{{ validation_editors.minimal }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

The coverage template now creates only the validation_editors.default job (..._6000.3), but this nightly dependency resolves to the minimal-editor key (..._6000.0). Because that key does not exist, the develop_nightly pipeline cannot resolve its dependencies. Reference validation_editors.default here, or generate a minimal-editor coverage job as well.

🤖 Helpful? 👍/👎

@michalChrobot michalChrobot changed the title [NGOv2.X] Adjusting CI after 3.X release ci: [NGOv2.X] Adjusting CI after 3.X release Sep 16, 2026
@codecov-github-com

codecov-github-com Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-2.0.0    #4162   +/-   ##
==============================================
  Coverage          74.10%   74.10%           
==============================================
  Files                172      172           
  Lines              28127    28127           
==============================================
  Hits               20844    20844           
  Misses              7283     7283           
Flag Coverage Δ
NGOv2_project_testproject_ubuntu 73.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
com.unity.netcode.gameobjects 74.10% <ø> (ø)

ℹ️ Need help interpreting these results?

@michalChrobot
michalChrobot merged commit 47bd434 into develop-2.0.0 Sep 18, 2026
125 of 133 checks passed
@michalChrobot
michalChrobot deleted the ngo/develop-ci-adjustmnent branch September 18, 2026 10:47
michalChrobot added a commit that referenced this pull request Sep 18, 2026
* Added Wrench cap on supported editors

* CI adjustments for new editor setup

* Updated Wrench and regenerated recipes

* typo

* Disabled more CoreCLR tests

* Adjusted pr-supervisor

* Added branch to github workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant