trunk shadow changes: com.unity.netcode.gameobjects - #4154
pets-svc[bot] wants to merge 3 commits into
Conversation
|
|
There was a problem hiding this comment.
💡 Harness Review
I examined the CoreCLR-conditional NUnit exclusions across the runtime tests, including their imports and fixture/test discovery scope, along with the build-script argument fix and release metadata update. The changes consistently preserve normal-build test execution while marking only the documented CoreCLR failures explicit, and the metadata aligns with the package version.
Reviewed commit dcbf52f
🤖 Helpful? 👍/👎
|
Check the configuration's TOML syntax, permitted settings, and size limit. See the error below. Error message: Configuration content:# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/
[github_app]
handle_pr_actions = ['opened', 'ready_for_review'] # PR events that auto-run pr_commands
pr_commands = ["/harness-review"] # what runs on those events
reviewer_commands = ["/harness-review"] # what runs when @u-pr is added as reviewer
|
7183606 to
dcbf52f
Compare
This PR contains changes made to the
trunkcopy ofcom.unity.netcode.gameobjects.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.The bot commit dcbf52f was created on top of the package release commit, and so this PR contains unrelated older commits. You may need to change the PR target branch (by clicking the pencil icon next to the PR title), or cherrypick the bot commit to a freshly created branch.
Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.netcode.gameobjectsbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.