Avoid tiny numpy arrays in numba: optimize area.py - #1701
Merged
Conversation
Sevans711
added
scalability
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
Benchmarks that have got worse:
|
cmdupuis3
approved these changes
Sep 1, 2026
cmdupuis3
left a comment
cmdupuis3
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, no issues in testing or benchmarking, and the approach here is fine.
dylannelson
approved these changes
Sep 2, 2026
dylannelson
left a comment
dylannelson
left a comment
Member
There was a problem hiding this comment.
Was able to create the environment, run the the tests, observe the speed increases, and ran across no problems. Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1699 (sub-issue of #1648)
Overview
Optimizes numba routines in
uxarray/grid/area.pyto avoid constructing many tiny numpy arrays inside numba routines, as discussed in #1648. Locally I saw roughly 4x speedup in a few face areas computations; hopefully ASV benchmarks will show similar improvements.Minor note: intentionally left quadrature_dg and dw as numpy arrays because those are only constructed once.
Small expansions of PR scope:
order, instead of silently returning zeros. Added corresponding regression test in test_areas.py.if gaussianout offor p in range(n_weights)in_face_area_from_quadrature. This surely has negligible impact compared to the other changes, but maybe matters a tiny amount?PR Checklist
General
Testing & Benchmarking
AI Disclosure
AI Usage: Claude discussions, GitHub Copilot's inline code suggestions.