deps: Bump js-yaml from 4.3.1 to 5.4.1 - #1558
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.1 to 5.4.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.3.1...5.4.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.4.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
306a1a6 to
4d07c49
Compare
f114cad to
10c9542
Compare
| // See https://github.com/nodeca/js-yaml/issues/456 and https://github.com/nodeca/js-yaml/pull/381 | ||
| configs = jsyaml.loadAll(configFile, undefined, { | ||
| // Using loadAll with CORE_SCHEMA (equivalent of v4's DEFAULT_SAFE_SCHEMA) to pass "filename". | ||
| configs = jsyamlLoadAll(configFile, undefined, { |
There was a problem hiding this comment.
The comment was already outdated, and with the upgrade to js-yaml v4, it was already removed: SAP/ui5-project#380
However, it seems that another PR (SAP/ui5-project#457), that was started before the upgrade did re-introduce the code/comment again, and referenced jsyaml.DEFAULT_SAFE_SCHEMA which already in js-yaml v4 is undefined, so the default was used.
Are you sure that the CORE_SCHEMA is equivalent to DEFAULT_SAFE_SCHEMA, or rather the default schema of v4, as DEFAULT_SAFE_SCHEMA did not exist anymore in js-yaml v4?
One important aspect of yaml parsing is merge keys (<<:). This is widely used by custom task/middleware configuration (e.g. https://github.com/ui5-community/ui5-ecosystem-showcase/tree/main/packages/ui5-tooling-modules).
We should keep that stable, and it looks like we do not have any tests that verify it.
10c9542 to
a1dec9b
Compare
Bumps js-yaml from 4.3.1 to 5.4.1.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
e5a3ba05.4.1 releasede54dea3Hard-limit merge sequence size to 100dfd3a29Cleanup 6a8e05f, #7976a8e05ffix: count empty merge sources against maxTotalMergeKeys (#797)6b4ff5e5.4.0 released3b3625eUpdate changelog4f25a74Fix file name3bd003bExpose new scalar styling APIfbb3e9dRemove regex lookbehind for ES2015 compatibilityd43c185FixflowSkipColonSpaceby forcingquoteFlowKeys