Skip to content

sorts: make merge_insertion_sort generic over Comparable items - #15417

Open
modusensus wants to merge 1 commit into
TheAlgorithms:masterfrom
modusensus:feat/merge-insertion-sort-comparable
Open

modusensus wants to merge 1 commit into
TheAlgorithms:masterfrom
modusensus:feat/merge-insertion-sort-comparable

Conversation

@modusensus

Copy link
Copy Markdown

Describe your change

  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

Part of #15234 — this generalizes merge_insertion_sort (and its helpers binary_search_insertion, merge, sortlist_2d) so they accept any mutually comparable items, mirroring the Comparable Protocol pattern already merged for insertion_sort, tree_sort, shell_sort and others. All existing doctests are unchanged, including the permutations test.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 23, 2026
@cclauss

cclauss commented Sep 23, 2026

Copy link
Copy Markdown
Member

ON HOLD: Our focus is on merging or closing old pull requests before October 1st.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files on hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants