Conversation
Follow-up to TheAlgorithms#15384. Replace the ``right: int | None`` sentinel on the recursive path with a thin wrapper that defaults ``right`` once, then delegates to a nested ``_search(left, right)`` core whose indices are always concrete ints. This matches the wrapper/core shape already used by ``binary_search.py`` and keeps the recursion flat so the window can only shrink.
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
cclauss
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15384, per @cclauss's preference for the wrapper/core shape over the
Nonesentinel on the recursive path.What changed
binary_search_by_recursioninsearches/exponential_search.pynow:right = len(...) - 1defaulting once, in the outer function, and_search(left, right)core whoseleft/rightare always concreteintindices.The recursion is now flat: the window can only shrink, there is no sentinel to re-expand it, so the runaway recursion that #15384 fixed (searching for an item below
sorted_collection[0]) stays fixed by construction rather than by aNone-check inside the recursive call.This mirrors the wrapper/core structure already used by the sibling
searches/binary_search.py(itsbinary_search_by_recursionwraps a nested_binary_search_recursivehelper), so the two files read consistently.The public signature is unchanged (
rightstill defaults to the last index), and all existing doctests pass.Verification
python3 -m doctest searches/exponential_search.py— 12/12 pass.