Skip to content

Update code review guidelines in SKILL.md - #15172

Merged
cclauss merged 3 commits into
masterfrom
update-code-review-guidelines
Sep 3, 2026
Merged

Update code review guidelines in SKILL.md#15172
cclauss merged 3 commits into
masterfrom
update-code-review-guidelines

Conversation

@cclauss

@cclauss cclauss commented Sep 3, 2026

Copy link
Copy Markdown
Member

Clarify criteria for code review and coding style.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

cclauss and others added 2 commits September 3, 2026 12:20
Clarify criteria for code review and coding style.
@algorithms-keeper algorithms-keeper Bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Sep 3, 2026
@cclauss
cclauss requested a review from poyea September 3, 2026 10:34
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 3, 2026
@cclauss
cclauss merged commit a394b80 into master Sep 3, 2026
6 checks passed
@cclauss
cclauss deleted the update-code-review-guidelines branch September 3, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR modified documentation files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants