Skip to content

ci: drop the libhdf5-dev system package entirely - #15158

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:ci/drop-libhdf5-dev-system-lib
Sep 2, 2026
Merged

ci: drop the libhdf5-dev system package entirely#15158
cclauss merged 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:ci/drop-libhdf5-dev-system-lib

Conversation

@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Describe your change:

Follow-up to #15157, per @cclauss's suggestion to try dropping libhdf5-dev as well.

This removes the sudo apt-get install --yes libhdf5-dev step from build.yml, project_euler.yml (both jobs) and sphinx.yml. The h5py wheels on PyPI (manylinux and musllinux, x86-64 and aarch64) are self-contained — they bundle their own copy of the HDF5 C library — so no system libhdf5 is required to import h5py or run the tests. Dropping the step removes a network/apt dependency and speeds CI up a little. CI on this PR confirms tests still pass without it.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Follow-up to TheAlgorithms#15157. h5py ships self-contained manylinux/musllinux
wheels (aarch64 included) that bundle their own HDF5, so no system
libhdf5 is needed to import or use it. Removing the apt-get step
speeds up CI and removes a network dependency; CI will confirm.
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Sep 2, 2026
@cclauss
cclauss enabled auto-merge (squash) September 2, 2026 10:40

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful!! Thanks much.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 2, 2026
@cclauss
cclauss merged commit e6b789a into TheAlgorithms:master Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants