docs: clarify React definition ownership - #111
Merged
tannerlinsley merged 5 commits intoSep 10, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe React quick-start guides update memoization guidance. They clarify chart rebuild behavior and application control through the dependency list. ChangesReact documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation-only update clarifies React chart-definition memoization behavior, with no identified merge-readiness risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
tannerlinsley
changed the title
|
View your CI Pipeline Execution ↗ for commit 25f0cbb
☁️ Nx Cloud last updated this comment at |
tannerlinsley
added a commit
that referenced
this pull request
Sep 10, 2026
* Allow line marks to configure caps and joins * Add Cartesian axis title styling * Allow configuring focus ring appearance * Preserve focus ring defaults for undefined options * Reserve the axis gutter in a right-to-left container A y scale with `side: 'right'` took its tick-label anchor from the physical side alone. That anchor reaches the DOM as SVG `text-anchor`, which resolves against inline base direction, so an RTL container painted the labels leftward into the plot. The margin pass then read those bounds correctly and reserved nothing on the right, widening the plot until it ran under its own labels. Anchor the far side with `end` once the container reads right to left, and mirror the same relation in the text estimator so a host without a DOM measurer resolves the identical layout. * Relock the difference-mark bundle increment The layout fix costs 73 B raw in shared code, which puts the difference-mark increment 0.02 kB over its ceiling. Gzip falls on most entries. * Harden focus styling and RTL text anchors * Complete RTL text direction support * Update combined release baselines * Address final review findings * Refresh PR 124 evidence on v0.17.0 * Sanitize XML-invalid SVG characters * Reduce XML sanitizer footprint * Escape custom SVG paths * Refresh PR 124 evidence after XML sanitization * docs: use the dynamic README header endpoint (#54) * docs: use the dynamic README header endpoint * docs: fix package README banner metadata --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com> * docs: complete the React custom tooltip example (#83) * Fixed typo in react/quick-start.md for Chart component code example * Complete React tooltip example --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com> * docs: clarify React definition ownership (#111) * Align react docs language to be similar to homepage "what does TanStack own" * Clarify React definition ownership * docs: describe React definition updates precisely --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com> * fix: preserve line continuity at zoom viewport edges (#53) * fix: preserve neighboring zoom rows * fix: preserve line continuity at zoom viewport edges * fix: preserve zoom line continuity at viewport edges --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com> --------- Co-authored-by: Wojciech Maj <kontakt@wojtekmaj.pl> Co-authored-by: 3li7alaki <alihalaki@outlook.com> Co-authored-by: Alem Tuzlak <t.zlak97@gmail.com> Co-authored-by: NEDIE.YASSIN <67947969+nedieyassin@users.noreply.github.com> Co-authored-by: Vikrant Pogula <vikrant.pogula@gmail.com> Co-authored-by: Ferréol DUBOIS COLI <80718477+Fefedu973@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the React quick-start memoization boundary. The application controls definition updates through the dependency list, and a new definition identity tells TanStack Charts to rebuild the scene while the React component and chart surface stay mounted.\n\nThe canonical source is updated in docs/framework/react/quick-start.md. The package copy is generated from that source.\n\n## Verification\n\n- Clean merge into current main.\n- Documentation sync leaves the generated package copy byte-identical to the canonical source.\n- Formatting and the full documentation contract pass.\n- Focused runtime and React tests pass, 58 tests.\n- No changeset is needed for this docs-only correction.
Summary by CodeRabbit