Fix exceptions in folders to tags - #1497
Merged
Merged
Conversation
CyanVoxel
added
Type: Fix
CyanVoxel
approved these changes
Sep 3, 2026
CyanVoxel
left a comment
CyanVoxel
left a comment
Member
There was a problem hiding this comment.
Thank you so much for this fix! While this specific feature has historically been under-maintined is slated to be replaced with the macros feature eventually, macros have continued to be pushed back so it's very nice to have this fix in the meantime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running "Folders to Tags", the folder list is empty and no tags can be created. This change fixes that issue.
Tasks Completed
gracefully handle empty parent tag
avoid database lock by first creating a list of entries, then writing new tags
Platforms Tested:
Tested For:
Context
I can see that "Folders to Tags" is deprecated, but I don't see how I can do the same with other existing functionality, and this was the very first feature I tried after installing TagStudio, which kind of gave a bad impression. Sorry for maybe not knowing all your conventions, I'm new to the project and only skimmed the style guide for this small change.