Add PluginContainer#resource and deprecate ResourceQueryable - #25
Open
Yeregorix wants to merge 2 commits into
Open
Add PluginContainer#resource and deprecate ResourceQueryable#25Yeregorix wants to merge 2 commits into
Yeregorix wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin Spark needs to access the
PluginResourceof aPluginContainerto determine thePathof the corresponding jar.It is currently using reflection to obtain the resource (see).
We can simply expose a getter. A
PluginContaineris always constructed from aPluginResourceanyway.Following that,
ResourceQueryablebecomes kinda useless and redundant so I deprecated it for a future removal.I also think that
container.resource().locateResource(path)could becomecontainer.resource().locate(path)for better clarity.The same goes for
openResource.