Bump gitpython to 3.1.62 and soupsieve to 2.9.2 - #365
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Oskar Haarklou Veileborg (BarrensZeppelin)
approved these changes
Sep 21, 2026
Member
There was a problem hiding this comment.
[agent] Approving. This is a comments-only pass over the three workflow files. Three notes inline, all about comments that speak to a reviewer of this diff rather than to someone reading the workflow later; the first is the one I'd actually act on.
[human] LGTM - thanks! 🎉
Both pins are flagged by pip-audit against the current lock: gitpython by CVE-2026-87817, CVE-2026-87818 and CVE-2026-87819, and the transitive soupsieve by GHSA-gjv8-xp57-g29c and GHSA-j934-xhv5-fg8f. Normalize the gitpython requirement to its lowercase PEP 503 name, matching uv.lock and the rest of the pins. Dependabot's uv updater errors on this entry with dependency_file_content_not_changed; the rename is a candidate fix for that. Move pip-audit out of the Unit Tests workflow into a Dependency Audit workflow with a daily schedule. The audit compares the lockfile against databases that publish continuously, so its result tracks the clock rather than the commit and needs a trigger to match. A failing scheduled run has no pull request to report on, so it opens a tracking issue and closes it once the audit is clean. Drop the paths filters from the pull_request triggers on Unit Tests and Version Check. A status check behind a paths filter produces no check context on a pull request that misses the filter, so those jobs cannot be marked required while the filters are in place. The push triggers keep theirs.
lelia
force-pushed
the
lelia/gitpython-3159-test-failures
branch
from
September 21, 2026 16:27
160d387 to
9121220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency bumps
Both pins are flagged by
pip-auditagainst the current lock.Supersedes #361.
Pin casing
GitPython==becomesgitpython==, the only mixed-case requirement in the project;uv.lockalready uses the normalized name. Dependabot's uv updater errors on this entry withdependency_file_content_not_changed, and the rename is a candidate fix. Inert either way, since PEP 503 names are case-insensitive to pip and uv and this was the only occurrence of the string.Audit scheduling
pip-auditmoves out of the Unit Tests workflow into a new Dependency Audit workflow with a daily cron, keeping the pull request trigger. The audit compares the lockfile against databases that publish continuously, so its result tracks the clock rather than the commit and needs a trigger to match. A failing scheduled run has no pull request to report on, so it opens a tracking issue and closes it once the audit is clean.Check triggers
The
pathsfilters come off thepull_requesttriggers for Unit Tests and Version Check. A status check behind apathsfilter produces no check context on a pull request that misses the filter, so those jobs cannot be marked required while the filters are in place. Thepushtriggers keep theirs. Each job finishes in under a minute.Verification