feat: add hub filter to devices command - #847
Open
sungmpar wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d827be4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hubfilter todeviceswhile preserving-Hfor--healthZ-Wave, Edge Child, and Virtual devices
verbose output behavior
Root cause
The devices list API has no hub filter, and hub membership can span multiple
parent-device levels. The CLI previously forwarded only API-supported filters
and did not reconstruct device topology, so users with multiple hubs could not
isolate every device joined to one hub, especially nested child devices.
When another list filter narrows the candidates, the implementation loads one
unfiltered device list for ancestry lookup. Missing parents and cycles fail
closed, duplicate candidates are removed, and the selected hub itself is not
returned.
Verification
npm run test -- --runTestsByPath src/__tests__/commands/devices.test.ts --no-watchman(20 of 20 tests passed)npm run buildnode dist/src/run.js devices --helpnpm run lintnpm run test -- --no-watchman(175 suites and 1,577 tests passed)git diff --checkThe built help shows long-form
--hub, retains-Hfor--health, andincludes a hub-filter example. The README generator ran during the build and
produced no tracked README change.
Verification used repository-native mocked devices; no live SmartThings account
or hardware mutation was performed.
Fixes #588
Checklist
npm run lintproduces no warnings/errors)