fix(frontend): keep the DataFast signup goal named signup - #14173
Conversation
### Why #14167 renamed the goal to `signup_completed` to match the "Site to Paid" funnel step as it read at the time. Since that merged, two things changed: - `DATAFAST_API_KEY` was set in Vercel production, so the goal started landing — 4 `signup` completions recorded so far. - The funnel step was updated to match what production actually sends: it is now "✍️ Signup" with `goalName: "signup"` (updated 2026-08-25T20:27Z). So `signup` is the correct name, and shipping `signup_completed` to production would silently break the funnel step that is now working. ### What changed Point `ACCOUNT_CREATED_GOAL` back at `signup` and update the comment to name the funnel step it is coupled to. The constant and the once-per-instance misconfiguration reporting from #14167 are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013giMLqpaUWaT4iZemCK3CK
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
WalkthroughThe change removes explanatory comments from the DataFast server module and its tests. Runtime logic, exported functions, and test assertions remain unchanged. ChangesDataFast comment cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change restores the production DataFast signup goal name without altering authentication, signup flow, or data handling, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013giMLqpaUWaT4iZemCK3CK
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #14173 +/- ##
==========================================
- Coverage 80.27% 80.25% -0.02%
==========================================
Files 3264 3264
Lines 250775 250772 -3
Branches 23243 23244 +1
==========================================
- Hits 201301 201252 -49
+ Misses 44297 44267 -30
- Partials 5177 5253 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
#14167 renamed the goal to
signup_completed, matching the "Site to Paid" funnel step as it read at the time. Since that merged, two things changed:DATAFAST_API_KEYwas set in Vercel production, so the goal started landing. DataFast now records 4signupcompletions (last 3 days).goalName: "signup"(updated2026-08-25T20:27Z, after fix(frontend): send the DataFast signup goal under the name the funnel expects #14167 merged at19:16Z).So
signupis the correct name. Shippingsignup_completedto production would silently zero out the funnel step that is now working — the same failure #14167 set out to fix, in the opposite direction.What changed
ACCOUNT_CREATED_GOALback atsignup.The behaviour from #14167 is otherwise unchanged: a missing or malformed
DATAFAST_API_KEYis reported once per server instance rather than once per signup.Testing
vitest run src/services/analytics src/app/(no-navbar)/signup src/app/(platform)/auth/callback— 54 passed🤖 Generated with Claude Code
https://claude.ai/code/session_013giMLqpaUWaT4iZemCK3CK
Note
Low Risk
Analytics goal string and test expectations only; no auth, data, or signup flow logic changes.
Overview
Reverts the server-side DataFast account created goal from
signup_completedback tosignupso production events align with the updated “Site to Paid” funnel step (goalName: "signup").The POST body to
https://datafa.st/api/v1/goalsand related tests now expectname: "signup"again viaACCOUNT_CREATED_GOAL. Explanatory comments added in the prior rename are removed; once-per-instance Sentry reporting for missing or malformedDATAFAST_API_KEYis unchanged.Reviewed by Cursor Bugbot for commit 1156a4f. Bugbot is set up for automated code reviews on this repo. Configure here.