Skip to content

fix(frontend): keep the DataFast signup goal named signup - #14173

Merged
ntindle merged 2 commits into
devfrom
fix/datafast-goal-name-signup
Aug 25, 2026
Merged

fix(frontend): keep the DataFast signup goal named signup#14173
ntindle merged 2 commits into
devfrom
fix/datafast-goal-name-signup

Conversation

@ntindle

@ntindle ntindle commented Aug 25, 2026

Copy link
Copy Markdown
Member

Why

#14167 renamed the goal to signup_completed, matching the "Site to Paid" funnel step as it read at the time. Since that merged, two things changed:

So signup is the correct name. Shipping signup_completed to production would silently zero out the funnel step that is now working — the same failure #14167 set out to fix, in the opposite direction.

What changed

The behaviour from #14167 is otherwise unchanged: a missing or malformed DATAFAST_API_KEY is reported once per server instance rather than once per signup.

Testing

  • vitest run src/services/analytics src/app/(no-navbar)/signup src/app/(platform)/auth/callback — 54 passed
  • Funnel definition and goal counts verified against the DataFast API

🤖 Generated with Claude Code

https://claude.ai/code/session_013giMLqpaUWaT4iZemCK3CK


Note

Low Risk
Analytics goal string and test expectations only; no auth, data, or signup flow logic changes.

Overview
Reverts the server-side DataFast account created goal from signup_completed back to signup so production events align with the updated “Site to Paid” funnel step (goalName: "signup").

The POST body to https://datafa.st/api/v1/goals and related tests now expect name: "signup" again via ACCOUNT_CREATED_GOAL. Explanatory comments added in the prior rename are removed; once-per-instance Sentry reporting for missing or malformed DATAFAST_API_KEY is unchanged.

Reviewed by Cursor Bugbot for commit 1156a4f. Bugbot is set up for automated code reviews on this repo. Configure here.

### Why

#14167 renamed the goal to `signup_completed` to match the "Site to Paid"
funnel step as it read at the time. Since that merged, two things changed:

- `DATAFAST_API_KEY` was set in Vercel production, so the goal started landing
  — 4 `signup` completions recorded so far.
- The funnel step was updated to match what production actually sends: it is
  now "✍️ Signup" with `goalName: "signup"` (updated 2026-08-25T20:27Z).

So `signup` is the correct name, and shipping `signup_completed` to production
would silently break the funnel step that is now working.

### What changed

Point `ACCOUNT_CREATED_GOAL` back at `signup` and update the comment to name
the funnel step it is coupled to. The constant and the once-per-instance
misconfiguration reporting from #14167 are unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013giMLqpaUWaT4iZemCK3CK
@ntindle
ntindle requested a review from a team as a code owner August 25, 2026 20:35
@ntindle
ntindle requested review from Bentlybro and Pwuts and removed request for a team August 25, 2026 20:35
@github-project-automation github-project-automation Bot moved this to 🆕 Needs initial review in AutoGPT development kanban Aug 25, 2026
@github-actions github-actions Bot added cla: pending CLA not yet signed by all contributors platform/frontend AutoGPT Platform - Front end labels Aug 25, 2026
@github-actions github-actions Bot added size/s cla: signed CLA signed by all contributors and removed cla: pending CLA not yet signed by all contributors labels Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59a63308-f0a1-48b4-9662-27f1bb09c26d

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa2a1a and 1156a4f.

📒 Files selected for processing (2)
  • autogpt_platform/frontend/src/services/analytics/datafast-server.test.ts
  • autogpt_platform/frontend/src/services/analytics/datafast-server.ts
💤 Files with no reviewable changes (2)
  • autogpt_platform/frontend/src/services/analytics/datafast-server.ts
  • autogpt_platform/frontend/src/services/analytics/datafast-server.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (9)
  • GitHub Check: check API types
  • GitHub Check: end-to-end tests
  • GitHub Check: lint
  • GitHub Check: integration_test
  • GitHub Check: Build, smoke, and scan (linux/amd64)
  • GitHub Check: Build, smoke, and scan (linux/arm64)
  • GitHub Check: Analyze (typescript)
  • GitHub Check: Analyze (python)
  • GitHub Check: Check PR Status

Walkthrough

The change removes explanatory comments from the DataFast server module and its tests. Runtime logic, exported functions, and test assertions remain unchanged.

Changes

DataFast comment cleanup

Layer / File(s) Summary
Remove explanatory comments
autogpt_platform/frontend/src/services/analytics/datafast-server.ts, autogpt_platform/frontend/src/services/analytics/datafast-server.test.ts
Removed comments describing configuration error reporting, test isolation, and the DataFast funnel-step assertion. The related code remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1156a

This localized change restores the production DataFast signup goal name without altering authentication, signup flow, or data handling, so no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: pwuts, bentlybro

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: restoring the DataFast signup goal name to "signup".
Description check ✅ Passed The description accurately explains the goal-name change, production context, unchanged reporting behavior, and testing performed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/datafast-goal-name-signup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size/m and removed size/s labels Aug 25, 2026
@ntindle
ntindle enabled auto-merge August 25, 2026 20:39
@github-project-automation github-project-automation Bot moved this from 🆕 Needs initial review to 👍🏼 Mergeable in AutoGPT development kanban Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (b4d81e1) to head (1156a4f).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #14173      +/-   ##
==========================================
- Coverage   80.27%   80.25%   -0.02%     
==========================================
  Files        3264     3264              
  Lines      250775   250772       -3     
  Branches    23243    23244       +1     
==========================================
- Hits       201301   201252      -49     
+ Misses      44297    44267      -30     
- Partials     5177     5253      +76     
Flag Coverage Δ
platform-frontend 57.38% <100.00%> (-0.04%) ⬇️
platform-frontend-e2e 28.61% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Platform Backend 85.58% <ø> (ø)
Platform Frontend 59.90% <100.00%> (-0.12%) ⬇️
AutoGPT Libs ∅ <ø> (∅)
Classic AutoGPT 28.43% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntindle
ntindle added this pull request to the merge queue Aug 25, 2026
Merged via the queue into dev with commit 571df3a Aug 25, 2026
43 checks passed
@ntindle
ntindle deleted the fix/datafast-goal-name-signup branch August 25, 2026 21:22
@github-project-automation github-project-automation Bot moved this to Done in Frontend Aug 25, 2026
@github-project-automation github-project-automation Bot moved this from 👍🏼 Mergeable to ✅ Done in AutoGPT development kanban Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: signed CLA signed by all contributors platform/frontend AutoGPT Platform - Front end size/m

Projects

Status: ✅ Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants