cross-crate: unused deps/features (5 passes) - #1922
Merged
Merged
Conversation
Remove Cargo edges with no rust path in the owning crate: tracedecay thiserror, dirs, notify, and ignore; maintenance's target libc; and mcp schemars. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
The normal dependency already supplies the same crate and features to tests: tracedecay sha2, tracedecay-cli ureq, and hotpath-guard hotpath. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Normal edges already provide the same crate: code-index-runtime and maintenance tempfile, and store-runtime graph-db. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
tracedecay glob, toml, hex, and libc are test links, so they move to dev-dependencies. Project temporal-query is optional behind test-helpers, which is the only compiler of that fixture. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
criterion 0.5.1's html_reports feature is empty and unreferenced. tracedecay's temporal-query path is test-helpers only, so the edge is optional behind that feature. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simplifyis now a commitlint type so the pass commits type-check.Motivation
Wave lens A: unused
Cargo.tomldependency edges and dead feature flags. Open simplify PRs #1892–#1910 already own several manifests (notably #1898:tracedecay-agent-hosts,tracedecay-application,tracedecay-automation-runtime,tracedecay-graph-query,tracedecay-private-fs). Those files were left alone, includingtracedecay-application'scriterionhtml_reportsflag.Changes
Pass 1 — no Rust path in the owning crate:
tracedecay:thiserror,dirs,notify,ignoretracedecay-maintenance: targetlibctracedecay-mcp:schemarsPass 2 — dev-dependencies that repeat an unconditional normal dependency:
tracedecay: devsha2tracedecay-cli: devureqtracedecay-hotpath-guard: devhotpathPass 3 — same duplicate-dev pattern:
tracedecay-code-index-runtime: devtempfiletracedecay-maintenance: devtempfiletracedecay-store-runtime: devtracedecay-graph-dbPass 4 — fixture-only production edges:
tracedecay:glob,toml, and targetlibcmoved to dev-dependencies; normalhexremoved (devhexremains)tracedecay-project:tracedecay-temporal-queryis optional and enabled bytest-helpersPass 5 — inert feature flag and a test-helpers-only edge:
tracedecay,tracedecay-graph-db,tracedecay-global-db,tracedecay-code-index: dropcriterionhtml_reports(locked criterion 0.5.1 defines that feature as empty, and no source references it)tracedecay:tracedecay-temporal-queryis optional behindtest-helpers(the session-temporal bench fixture is compiled into the lib under that feature; the dev-dependency keepstest-helperson the query crate for this package's own tests)Edges that look unused but are not were kept:
tracedecay-code-extractionandtracedecay-lcmare named by the roothotpathfeature, and CLI dev-depstracedecay-lcm/tracedecay-session-temporal-storeare used through#[path]fixtures outside the crate.Test plan
cargo check --lockedof the touched libraries, includingtracedecayandtracedecay-clicargo test --locked --offline --no-run --features test-helpers -p tracedecay --bench session_temporal --example bench_extractcargo test --locked --offline --no-run -p tracedecay-maintenance --libcargo test --locked --offline --no-run --features test-helpers -p tracedecay-project --libcargo nextest run --workspaceandcargo clippywere not runChecklist
CHANGELOG.mdupdated — not a user-facing release change.envfiles includedproduction, language tiers, and hotpath backends are untouched)