Skip to content

cross-crate: dead pub surface (5 passes) - #1920

Merged
ScriptedAlchemy merged 5 commits into
masterfrom
cursor/dead-pub-surface-0fe3
Sep 21, 2026
Merged

ScriptedAlchemy merged 5 commits into
masterfrom
cursor/dead-pub-surface-0fe3

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Five sequential passes from master delete public items with no workspace callers. Behavior of remaining call paths is unchanged.
  • MCP tool entry points and CLI flags are untouched. simplify: cross-crate workspace (5 passes) #1898's symbols were left in place.
  • No dashboard UI, hotpath vendor edits, or pull_request workflow restore.

Motivation

Public (pub) methods, types, and the uncalled orphan-relink apply path were still exported across crates after #1898. Each deletion was checked against a workspace-wide identifier scan of Rust sources (definitions vs code uses), then compiled.

Changes

Pass 1 — domain helpers (0f09869751)

  • GitObjectFormatV1::oid_hex_len
  • BranchNameSeparatorV1::as_char
  • ProximityContributionV1::suppressed_duplicate
  • VectorWatermark::merge_max

Pass 2 — graph-query analytical reads (9094c5adb0)

  • GraphQueryManager::get_file_dependencies and VerifiedGraphQuery::get_file_dependencies
  • GraphQueryManager::get_node_metrics, VerifiedGraphQuery::get_node_metrics, and NodeMetrics
  • GraphQueryManager::health_file_aggregates and VerifiedGraphQuery::health_file_aggregates

Pass 3 — orphan-relink apply and saturation (f5af7875e9)

  • ProfileRegistryMaintenance::apply_orphan_relink
  • apply_registry_orphan_relink_report and apply_single_registry_orphan_relink_report (global-db and the unused test-support wrappers)
  • RegistryOrphanRelinkApplyReport
  • private apply/preflight helpers that existed only for that path (encode_registry_identity, preflight_registry_orphan_relink, record_batch_owner, query_optional_text, query_all_text, apply_registry_orphan_relink_rows)
  • GitHubStackSignalAppendOutcomeV1::is_saturated

Planner types and graph_scope_location_drift_is_repairable stay; the latter is now test-only.

Pass 4 — session store forwarders (b32c04fa2a)

  • SessionStoreAccess::lcm_payload_health_detail and RegisteredGlobalDb::lcm_payload_health_detail
  • SessionStoreAccess::lcm_preview_payload_gc and RegisteredGlobalDb::lcm_preview_payload_gc
  • SessionStoreAccess::upsert_transcript_projection_batches and RegisteredGlobalDb::upsert_transcript_projection_batches
  • CursorComposerHost::ingest_user
  • trust_bucket, clamp_trust, and HIGH_TRUST_THRESHOLD

Pass 5 — repair and entry wrappers (4091e19243)

  • Connection::repair_incremental_auto_vacuum
  • ExactSql::repair_incremental_auto_vacuum and repair_incremental_auto_vacuum_async
  • WriterCommand::Vacuum, AuthorizedDatabaseOperation::Vacuum, and ExactSqlWriteIntent::Vacuum (only reached by that repair)
  • CollectionPlan::collectable_bytes and UnregisteredCollectionPlan::collectable_bytes
  • DiagnosticsCache::run_for_generation (run_with_generation and WorkspaceChange remain cfg(test))
  • Chunker::with_sensitivity_level
  • PrimitiveProjectRuntime::teardown
  • TraceDecay::open_read_only (options entry point stays)
  • SourceCanonicalRefetchAuthorityV1::authorizes (matches stays; production admission still calls it)
  • ResolvedOccurrence::certainty and ResolutionCertainty
  • TranscriptWritePolicy::ProjectionOnly and the projection-only transcript write path, which only the deleted upsert constructed

Test plan

  • cargo check --locked --lib --tests --features test-helpers on every touched crate
  • cargo clippy --locked --lib --tests --features test-helpers -- -D warnings on every touched crate
  • Full cargo nextest run --workspace (not run; scope is uncalled public items)

Checklist

  • CHANGELOG.md updated (no user-facing release note; unpublished internal API)
  • No secrets, credentials, or .env files included
  • Breaking changes documented (workspace-only publish = false items with no callers)
Open in Web Open in Cursor 

cursoragent and others added 5 commits September 20, 2026 19:40
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4091e19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 6c43c7f into master Sep 21, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants