cross-crate: dead pub surface (5 passes) - #1920
Merged
Merged
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestworkflow restore.Motivation
Public (
pub) methods, types, and the uncalled orphan-relink apply path were still exported across crates after #1898. Each deletion was checked against a workspace-wide identifier scan of Rust sources (definitions vs code uses), then compiled.Changes
Pass 1 — domain helpers (
0f09869751)GitObjectFormatV1::oid_hex_lenBranchNameSeparatorV1::as_charProximityContributionV1::suppressed_duplicateVectorWatermark::merge_maxPass 2 — graph-query analytical reads (
9094c5adb0)GraphQueryManager::get_file_dependenciesandVerifiedGraphQuery::get_file_dependenciesGraphQueryManager::get_node_metrics,VerifiedGraphQuery::get_node_metrics, andNodeMetricsGraphQueryManager::health_file_aggregatesandVerifiedGraphQuery::health_file_aggregatesPass 3 — orphan-relink apply and saturation (
f5af7875e9)ProfileRegistryMaintenance::apply_orphan_relinkapply_registry_orphan_relink_reportandapply_single_registry_orphan_relink_report(global-db and the unused test-support wrappers)RegistryOrphanRelinkApplyReportencode_registry_identity,preflight_registry_orphan_relink,record_batch_owner,query_optional_text,query_all_text,apply_registry_orphan_relink_rows)GitHubStackSignalAppendOutcomeV1::is_saturatedPlanner types and
graph_scope_location_drift_is_repairablestay; the latter is now test-only.Pass 4 — session store forwarders (
b32c04fa2a)SessionStoreAccess::lcm_payload_health_detailandRegisteredGlobalDb::lcm_payload_health_detailSessionStoreAccess::lcm_preview_payload_gcandRegisteredGlobalDb::lcm_preview_payload_gcSessionStoreAccess::upsert_transcript_projection_batchesandRegisteredGlobalDb::upsert_transcript_projection_batchesCursorComposerHost::ingest_usertrust_bucket,clamp_trust, andHIGH_TRUST_THRESHOLDPass 5 — repair and entry wrappers (
4091e19243)Connection::repair_incremental_auto_vacuumExactSql::repair_incremental_auto_vacuumandrepair_incremental_auto_vacuum_asyncWriterCommand::Vacuum,AuthorizedDatabaseOperation::Vacuum, andExactSqlWriteIntent::Vacuum(only reached by that repair)CollectionPlan::collectable_bytesandUnregisteredCollectionPlan::collectable_bytesDiagnosticsCache::run_for_generation(run_with_generationandWorkspaceChangeremaincfg(test))Chunker::with_sensitivity_levelPrimitiveProjectRuntime::teardownTraceDecay::open_read_only(options entry point stays)SourceCanonicalRefetchAuthorityV1::authorizes(matchesstays; production admission still calls it)ResolvedOccurrence::certaintyandResolutionCertaintyTranscriptWritePolicy::ProjectionOnlyand the projection-only transcript write path, which only the deleted upsert constructedTest plan
cargo check --locked --lib --tests --features test-helperson every touched cratecargo clippy --locked --lib --tests --features test-helpers -- -D warningson every touched cratecargo nextest run --workspace(not run; scope is uncalled public items)Checklist
CHANGELOG.mdupdated (no user-facing release note; unpublished internal API).envfiles includedpublish = falseitems with no callers)