test(daemon): initialize rmcp target project before the engine - #1335
ScriptedAlchemy merged 3 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Sort clone bodies after partitioned segment restore so cold load keeps canonical occurrence order. Keep invalid-cursor rebuild on the V14 admission writer, and publish Ready before seating owners. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Rewrite page-alignment, invalid-cursor, overflow, and graph-off decode probes for clone-body pages and V14 successor artifacts. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Performance Comparison
|
cab9b3a
into
codex/tracedecay-total-redesign-plan-reopened
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f991b1205
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.publish_text_progress_phase(CodeIndexBuildPhaseV1::Ready, 0, 0); | ||
| self.install_artifact_owners(reader, reader_reservation)?; |
There was a problem hiding this comment.
Publish Ready only after owner installation succeeds
If install_artifact_owners returns an error—for example because the reader exceeds its admitted ceiling or the reservation cannot shrink—the progress snapshot has already been permanently advanced to Ready, while no query owners were installed. The caller latches the projection failure but does not roll this phase back, so dashboard/MCP progress reports a ready generation that cannot serve queries; coordinate these transitions atomically or publish Ready only after successful installation.
AGENTS.md reference: AGENTS.md:L9-L12
Useful? React with 👍 / 👎.
Summary
Three commits on
agent/863-rmcp-target-fixture→codex/tracedecay-total-redesign-plan-reopened:rmcp_routemounted project before the in-process engine exists.clone_bodiesafter partitioned segment restore; keep incompatible-cursor rebuild on the V14 admission writer; publish textReadybefore seating owners.Motivation (#863)
selected_target_rmcp_…failed 2/40 under--test-threads=16with typeddatabase is lockedbecausemount_rmcp_targetran exclusive maintenance while the fixture engine was live on the same profile.Evidence
database is lockedon the target identity.7f991b120(supersedes86292a42e).Checklist
7f991b120