fix(code-index-runtime): gate unix-mode artifact-root test to unix - #1328
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
|
Local cross-compile proof for this head (
Handing this PR to the Windows lane per the 21:28 UTC ownership map; #921/#922 close on native Windows green for their named tests. |
Performance Comparison
|
Leave the unix-mode compile gate on agent/921-windows-build-gate. This PR keeps only the Windows FileRenameInfoEx RootDirectory fix. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
7cb0aa8
into
codex/tracedecay-total-redesign-plan-reopened
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This PR only restored It does not resolve the named #921 path/authorization rows or the #922 fixture rows. Those product commits were already ancestors of the campaign base. Close each issue only after native Windows shards pass its named tests. Squash is on |
Leave the unix-mode compile gate on agent/921-windows-build-gate. This PR keeps only the Windows FileRenameInfoEx RootDirectory fix. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Summary
#[cfg(unix)]ontext_artifact_builder_creates_an_owner_private_artifacts_root, whose body importsstd::os::unix::fs::PermissionsExtand asserts a POSIXmode().Motivation
Build Windows testsfails on the campaign base at the first crate that does not compile for Windows, so no native Windows shard has executed since the #921 / #922 fixes landed (9c3b34bd0,4e239df9b). Latest evidence: run 34982086570, jobBuild Windows tests:The test was introduced with
#[cfg(unix)]in15de2a71band lost the gate in the test splitd62bf238d. Its siblingtext_artifact_publish_rejects_a_permissive_artifacts_rootstill carries it. Production creates the root throughtracedecay_private_fs::create_private_directory, which has its own Windows path; the unix-mode observation is what is platform-specific here.Unblocks native Windows verification for #921 and #922 (both fixes are already ancestors of the base tip; the issues are open only as verification debt).
Changes
crates/tracedecay-code-index-runtime/src/code_index_scheduler/tests/serving.rs: one attribute line.Test plan
Build Windows testscompiles thetracedecay-code-index-runtimelib test on this PRChecklist
CHANGELOG.mdupdated — not applicable (test-only cfg gate).envfiles included