Skip to content

fix(code-index-runtime): gate unix-mode artifact-root test to unix - #1328

Merged
ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
agent/921-windows-build-gate
Sep 15, 2026
Merged

ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
agent/921-windows-build-gate

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Restore #[cfg(unix)] on text_artifact_builder_creates_an_owner_private_artifacts_root, whose body imports std::os::unix::fs::PermissionsExt and asserts a POSIX mode().

Motivation

Build Windows tests fails on the campaign base at the first crate that does not compile for Windows, so no native Windows shard has executed since the #921 / #922 fixes landed (9c3b34bd0, 4e239df9b). Latest evidence: run 34982086570, job Build Windows tests:

error[E0433]: cannot find `unix` in `os`
  --> crates\tracedecay-code-index-runtime\src\code_index_scheduler\tests\serving.rs:1261:18
error[E0599]: no method named `mode` found for struct `std::fs::Permissions` in the current scope
  --> crates\tracedecay-code-index-runtime\src\code_index_scheduler\tests\serving.rs:1280:10
error: could not compile `tracedecay-code-index-runtime` (lib test) due to 2 previous errors

The test was introduced with #[cfg(unix)] in 15de2a71b and lost the gate in the test split d62bf238d. Its sibling text_artifact_publish_rejects_a_permissive_artifacts_root still carries it. Production creates the root through tracedecay_private_fs::create_private_directory, which has its own Windows path; the unix-mode observation is what is platform-specific here.

Unblocks native Windows verification for #921 and #922 (both fixes are already ancestors of the base tip; the issues are open only as verification debt).

Changes

  • crates/tracedecay-code-index-runtime/src/code_index_scheduler/tests/serving.rs: one attribute line.

Test plan

Checklist

  • CHANGELOG.md updated — not applicable (test-only cfg gate)
  • No secrets, credentials, or .env files included
  • Breaking changes documented (if any) — none
Open in Web Open in Cursor 

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 009b853

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cursor Bot pushed a commit that referenced this pull request Sep 15, 2026
The owner-private artifact-mode gate is identical to PR #1328.
Keep only the #923 Git-fixture spelling change on this branch.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Local cross-compile proof for this head (009b853b6), since the hosted Build Windows tests job is slow to schedule:

  • hauler cc-7: cargo check --target x86_64-pc-windows-gnu -p tracedecay-code-index-runtime --tests0 errors, 4 warnings (pre-existing, unrelated to this file). The two errors from run 34982086570 (serving.rs:1261 E0433, serving.rs:1280 E0599) are gone.

Handing this PR to the Windows lane per the 21:28 UTC ownership map; #921/#922 close on native Windows green for their named tests.

@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopenedagent/921-windows-build-gate

Total Elapsed Time: 7.65s → 8.15s (+6.6%)
CPU Baseline: 81.43µs → 83.00µs (+1.9%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                              | P95                              | Total                           | % Total                      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 7.64s → 8.15s (+6.7%)            | 7.65s → 8.15s (+6.5%)            | 7.64s → 8.15s (+6.7%)           | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| domain.canonical.sha256                  | 85787 → 85787 (+0.0%)      | 34.43µs → 35.55µs (+3.3%)        | 108.16µs → 108.54µs (+0.4%)      | 2.95s → 3.05s (+3.4%)           | 38.63% → 37.42% (-3.1%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.workers.install               | 81 → 81 (+0.0%)            | 31.51ms → 36.60ms (+16.2%)       | 166.85ms → 222.04ms (+33.1%) ⚠️  | 2.55s → 2.96s (+16.1%)          | 33.39% → 36.38% (+9.0%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 5 → 5 (+0.0%)              | 298.92ms → 306.77ms (+2.6%)      | 351.54ms → 360.71ms (+2.6%)      | 1.49s → 1.53s (+2.7%)           | 19.55% → 18.82% (-3.7%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 722.70ms → 722.28ms (-0.1%)      | 1.01s → 1.01s (+0.0%)            | 1.45s → 1.44s (-0.7%)           | 18.91% → 17.73% (-6.2%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 28 → 28 (+0.0%)            | 46.69ms → 46.10ms (-1.3%)        | 319.03ms → 322.70ms (+1.2%)      | 1.31s → 1.29s (-1.5%)           | 17.10% → 15.84% (-7.4%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 5 → 5 (+0.0%)              | 185.39ms → 239.86ms (+29.4%) ⚠️  | 214.83ms → 290.72ms (+35.3%) ⚠️  | 926.95ms → 1.20s (+29.5%) ⚠️    | 12.13% → 14.72% (+21.4%) ⚠️  |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| query.artifact.batch.postings            | 5 → 5 (+0.0%)              | 219.94ms → 225.65ms (+2.6%)      | 250.35ms → 260.05ms (+3.9%)      | 1.10s → 1.13s (+2.7%)           | 14.39% → 13.84% (-3.8%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 4.03ms → 4.07ms (+1.0%)          | 6.55ms → 6.63ms (+1.2%)          | 1.11s → 1.12s (+0.9%)           | 14.53% → 13.77% (-5.2%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| domain.canonical.json_bytes              | 206681 → 206681 (+0.0%)    | 4.23µs → 5.32µs (+25.8%) ⚠️      | 4.45µs → 4.42µs (-0.7%)          | 873.59ms → 1.10s (+25.9%) ⚠️    | 11.43% → 13.48% (+17.9%)     |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.restore.file_admit            | 260 → 260 (+0.0%)          | 3.09ms → 3.62ms (+17.2%)         | 5.00ms → 6.81ms (+36.2%) ⚠️      | 803.48ms → 942.48ms (+17.3%)    | 10.51% → 11.56% (+10.0%)     |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.build.materialize_full        | 1 → 1 (+0.0%)              | 731.49ms → 726.05ms (-0.7%)      | 731.91ms → 726.14ms (-0.8%)      | 731.49ms → 726.05ms (-0.7%)     | 9.57% → 8.91% (-6.9%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| code_index.collect.materialize_full      | 1 → 1 (+0.0%)              | 718.78ms → 712.99ms (-0.8%)      | 718.80ms → 713.03ms (-0.8%)      | 718.78ms → 712.99ms (-0.8%)     | 9.40% → 8.75% (-6.9%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| 🆕 code_index.lexical_source.batch_stage | 0 → 6 (+100.0%) ⚠️         | 0.00ns → 116.05ms (+100.0%) ⚠️   | 0.00ns → 202.11ms (+100.0%) ⚠️   | 0.00ns → 696.28ms (+100.0%) ⚠️  | 0.00% → 8.54% (+100.0%) ⚠️   |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 5 → 5 (+0.0%)              | 127.22ms → 128.93ms (+1.3%)      | 144.70ms → 147.32ms (+1.8%)      | 636.09ms → 644.66ms (+1.3%)     | 8.32% → 7.91% (-4.9%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+
| 🗑️ code_index.build.assemble             | 2 → 0 (-100.0%) 🚀         | 278.24ms → 0.00ns (-100.0%) 🚀   | 284.95ms → 0.00ns (-100.0%) 🚀   | 556.48ms → 0.00ns (-100.0%) 🚀  | 7.28% → 0.00% (-100.0%) 🚀   |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+---------------------------------+------------------------------+

Generated with hotpath-rs

cursor Bot pushed a commit that referenced this pull request Sep 15, 2026
Leave the unix-mode compile gate on agent/921-windows-build-gate.
This PR keeps only the Windows FileRenameInfoEx RootDirectory fix.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review September 15, 2026 23:43
@ScriptedAlchemy
ScriptedAlchemy merged commit 7cb0aa8 into codex/tracedecay-total-redesign-plan-reopened Sep 15, 2026
24 of 38 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T23:45:57.065160Z 009b853 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

#921 and #922 stay open.

This PR only restored #[cfg(unix)] on text_artifact_builder_creates_an_owner_private_artifacts_root. Hosted Build Windows tests on exact head 009b853b6 succeeded (job 104563957072, 1h34m25s), which unblocks Windows shards for #1329/#1330.

It does not resolve the named #921 path/authorization rows or the #922 fixture rows. Those product commits were already ancestors of the campaign base. Close each issue only after native Windows shards pass its named tests.

Squash is on codex/tracedecay-total-redesign-plan-reopened as 7cb0aa881. Not master. #745 untouched.

cursor Bot pushed a commit that referenced this pull request Sep 15, 2026
Leave the unix-mode compile gate on agent/921-windows-build-gate.
This PR keeps only the Windows FileRenameInfoEx RootDirectory fix.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Sep 15, 2026
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Sep 15, 2026
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
ScriptedAlchemy added a commit that referenced this pull request Sep 16, 2026
Keep this branch to the Windows FileRenameInfoEx RootDirectory fix.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants