Fix bug introduced by PR#167 not covering all available currencies

[thai-truong]

Currently, there is an existing bug in monetize v1.13.0 introduced by #167 that attempted to implement additional logic for currency parsing discussed in #153.

Example of the bug:

• Expected:

"RM100".to_money    # #<Money fractional:10000 currency:MYR>
Monetize.parse("RM100")   # #<Money fractional:10000 currency:MYR>
Monetize.parse("100 RM")   # #<Money fractional:10000 currency:MYR>

• Reality:

[1] pry(main)> Monetize.parse("RM100")
=> #<Money fractional:10000 currency:USD>

[8] pry(main)> "RM100".to_money
=> #<Money fractional:10000 currency:USD>

[14] pry(main)> Monetize.parse("100 RM")
=> #<Money fractional:10000 currency:USD>

This PR aims to:

• Fix that bug.
• Implement the additional currency parsing logic in Version 1.11.0 broke parsing for Malaysian ringgit when using the symbol 'RM' #153.
• Improve parsing logic in general by validating parsed currency input against Money::Currency.all.map(&:iso_code).
• Update spec/monetize_spec.rb to accommodate for the aforementioned changes.

[jaredbeck]

Currently, there is an existing bug in monetize v1.13.0 ..

Does this bug only affect the Malaysian ringgit (MYR) or are other currencies affected? Thanks.

[thai-truong]

Currently, there is an existing bug in monetize v1.13.0 ..

Does this bug only affect the Malaysian ringgit (MYR) or are other currencies affected? Thanks.

This affects any currency that is not in Monetize::Parser::CURRENCY_SYMBOLS.values, according to this line in the code.

I've personally run into the aforementioned issue with Malaysian Ringgit (as "RM", not "MYR") and Australian Dollar (AUD) since neither of them are in Monetize::Parser::CURRENCY_SYMBOLS.values.

Monetize::Parser::CURRENCY_SYMBOLS's main purpose seems to be to map non-ISO currency symbols to their respective ISO-4217 currency code. That's why I think it is unsuitable to be used in the manner implemented in #167

What do you think? And thanks for taking a look!

[eloyesp]

I'm facing the same issue with:

"156,30 ARS".to_money("USD") # => Money(15630, "USD")

[eloyesp]

I've just double checked, the fix is already implemented in a9af12c (january) but not released...

[yukideluxe]

ops! thanks for double checking @eloyesp! I will release RIGHT NOW 😳 😳 😳 😳 😳 😳

[yukideluxe]

@eloyesp the bugfix has been released https://rubygems.org/gems/monetize/versions/2.0.1. Thanks!