Run explicit formatting in the background - #764
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-document and explicit-selection formatting currently block the server's event loop. Run document, range, and multiple-range formatting in a lazy background worker so other editor requests remain responsive.
The first explicit formatting request includes worker startup time. Custom formatter side effects now occur in the worker.
Validation: installed this branch independently and passed 45 formatting, handler, server-lifecycle, and LSP test cases with 352 assertions. Tests exercise all three request types, changed style options, disk saves, stale results, and live responsiveness/cancellation during a deliberately stalled formatter. Whitespace checks pass.
This PR contains only background formatting and its tests, based directly on
master. Supersedes the formatting portion of #762.Closes #251.