fix: treat custom element names as block-level HTML - #1624
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: treat custom element names as block-level HTML#1624BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Custom elements must contain a hyphen. Treat those tag names like other block-level elements so md_in_html and raw HTML blocks no longer wrap them in <p>. Fixes Python-Markdown#1246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom element names are required to contain a hyphen.
is_block_level()andmd_in_htmlpreviously only recognized a fixed list of block tags, so a standalone<a-b>…</a-b>was wrapped in<p>and themarkdownattribute on those tags was ignored.Treat any tag name that contains a hyphen as block-level (same treatment as
<div>). Inner Markdown still requires themarkdown/markdown="1"attribute. Inline use mid-paragraph stays span-level.Test plan
python -m unittest tests.test_syntax.blocks.test_html_blocks.TestHTMLBlocks.test_raw_custom_element tests.test_syntax.extensions.test_md_in_html.TestMdInHTML.test_custom_element_markdown_attr tests.test_syntax.extensions.test_md_in_html.TestMdInHTML.test_custom_element_md1 tests.test_syntax.extensions.test_md_in_html.TestMdInHTML.test_custom_element_inlinepython -m unittest discover tests)Fixes #1246