Initialize mutable Params after DAE discretization - #4030
Open
mameikagou wants to merge 2 commits into
Open
mameikagou wants to merge 2 commits into
mameikagou wants to merge 2 commits into
Conversation
blnicho
self-requested a review
September 1, 2026 19:09
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 917 917
Lines 109261 109278 +17
==========================================
+ Hits 98494 98507 +13
- Misses 10767 10771 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4009.
Summary/Motivation:
DAE discretization adds points to a
ContinuousSetafter indexedParamcomponents are constructed. Mutable Params with an explicit initializer therefore contain uninitializedParamDataat those new points.Changes proposed in this PR:
AI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional): Verified the original reproducer before and after the change. The complete
pyomo/dae/testsunittest suite passes: 178 tests, 33 skipped.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: