chore: make nbtac conflict with nbt_ac - #70
Merged
Conversation
Member
|
I would merge but lowkey im not sure if oneclient launcher would merge this in properly... |
Contributor
Author
|
It seems to work (I manually edited the local file and then removed write permission so that it doesn't overwrite). Though the error isn't great for the average user, it's just more obvious for support. I wonder if we can inject early in Poly+ and flag this or quietly prevent the older version of the mod from loading if the newer one is loaded... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mod dev is dumb and changed the mod ID between 1.x and 2.x?? I've seen at least two people crash with a
@Redirectconflict due to having both installed today. This should give them a clearer error message.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation