fix after call setMinMaxScaleX, when scaleX to bound value, chart wil… - #5391
Closed
renzhenfei wants to merge 2 commits into
Closed
renzhenfei wants to merge 2 commits into
renzhenfei wants to merge 2 commits into
Conversation
Contributor
|
Please can you show a before-this-change and a after-this-change screenshot ? |
Contributor
|
It will probably merged here AppDevNext/AndroidChart#138 |
Author
|
@hannesa2 chart_before_cut.mp4after chart_after_cut.mp4 |
Contributor
|
@renzhenfei Thank you I'll merge it |
Owner
|
Thank you. This is in 4.0.0-beta01: the pinch scale is limited before it is applied, so the chart no longer jumps when it reaches its scale limit. 4.0 is a rewrite in Kotlin, so the Java sources this patch touches no longer exist and it cannot be merged as it stands. It was reimplemented rather than merged, so the credit is yours. https://github.com/PhilJay/MPAndroidChart/releases/tag/v4.0.0-beta01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After call setMinMaxScaleX, when operate chart zoom, while scaleX or scaleY scale to max value or min value, the chart will jump.
PR Checklist:
Line data chart jumps during zoom #4489
PR Description
In default BarLineChartTouchListener file, when handle zoom event, source code just post scaleX or scaleY, no check after call postScale the scaleX or scaleY value is valid.
This change limit scale to minScale or maxScale when zoom.