Skip to content

fix: add output encoding in inject.js (CWE-79) #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

fix: add output encoding in inject.js (CWE-79) #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pat/inject/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import "../../core/polyfills"; // SubmitEvent.submitter for Safari < 15.4 and jsDOM
import $ from "jquery";
import DOMPurify from "dompurify";
import ajax from "../ajax/ajax";
import dom from "../../core/dom";
import events from "../../core/events";
Expand Down Expand Up @@ -473,7 +474,7 @@ const inject = {
// There might be multiple sources, so we need to loop over them.
// Access them with "innerHTML" or "outerHTML" depending on the sourceMod.
const sources_string = [...$sources].map(source => source[method]).join("\n");
wrapper.innerHTML = sources_string;
wrapper.innerHTML = DOMPurify.sanitize(sources_string);

for (const img of wrapper.content.querySelectorAll("img")) {
events.add_event_listener(
Expand Down Expand Up @@ -665,7 +666,7 @@ const inject = {

if (error_page_fragment) {
error_page = document.createElement("html");
error_page.innerHTML = event.jqxhr.responseText;
error_page.innerHTML = DOMPurify.sanitize(event.jqxhr.responseText);
error_page = error_page.querySelector(error_page_fragment);
}

Expand All @@ -675,7 +676,7 @@ const inject = {
method: "GET",
});
error_page = document.createElement("html");
error_page.innerHTML = await error_page_response.text();
error_page.innerHTML = DOMPurify.sanitize(await error_page_response.text());
error_page = error_page.querySelector(error_page_fragment || "body");
} catch {
// fall back to standard error message and ignore.
Expand Down