fix: correctly handle team members even if they are child team members - #238
Merged
mxmehl merged 2 commits intoSep 16, 2026
Merged
Conversation
typed-sigterm
changed the title
Contributor
Author
|
@mxmehl Could you please review these :) |
mxmehl
self-requested a review
August 12, 2026 13:51
mxmehl
changed the title
mxmehl
approved these changes
Sep 16, 2026
mxmehl
left a comment
mxmehl
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! Indeed, this has been a bug. I've tested it with two large orgs. In one, there were changes due to this PR, but they are actually reflecting the intended behaviour, so I wouldn't mark this as breaking.
mxmehl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #236. Tested with my org.
It might be a breaking change because someone may relies on the bug.