Fix crashes and a leaked client in the Avahi DNS-SD code. - #165
Merged
Merged
Conversation
michaelrsweet
approved these changes
Sep 16, 2026
michaelrsweet
added
bug
Member
|
Thanks, will be testing - was having some deadlock issues after the last changes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main crash was caused by
avahi_lock()skipping the mutex based on a context-widein_callbackflag. Another thread could then free Avahi objects while the monitor thread was using them, resulting in a crash.Also fixes monitor-thread shutdown and cleanup by waiting for the poll loop to exit cleanly, and frees the Avahi client during teardown.
Verified with DNS-SD churn and repeated
avahi-daemonrestarts; no crashes or assertions, with sockets and threads returning to normal levels.